Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize component image build times #460

Closed
Ark-kun opened this issue Dec 4, 2018 · 1 comment
Closed

Optimize component image build times #460

Ark-kun opened this issue Dec 4, 2018 · 1 comment
Assignees
@gaoning777 @hongye-sun
Labels
area/components kind/feature priority/p2

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 4, 2018

Right now almost all images take 10+ minutes to build.

 ├-·-✔ build-dataflow-predict-image         sample-test-crjch-440185506   11m       
 | ├-✔ build-dataflow-tfdv-image            sample-test-crjch-603211133   15m       
 | ├-✔ build-dataflow-tfma-image            sample-test-crjch-1561666893  13m       
 | ├-✔ build-dataflow-tft-image             sample-test-crjch-3403325369  12m       
 | ├-✔ build-dataproc-analyze-image         sample-test-crjch-3906523775  11m       
 | ├-✔ build-dataproc-create-cluster-image  sample-test-crjch-3415062594  10m       
 | ├-✔ build-dataproc-delete-cluster-image  sample-test-crjch-1546564173  10m       
 | ├-✔ build-dataproc-predict-image         sample-test-crjch-3930576650  11m       
 | ├-✔ build-dataproc-train-image           sample-test-crjch-1352006745  10m       
 | ├-✔ build-dataproc-transform-image       sample-test-crjch-1209413303  10m       
 | ├-✔ build-sample-tests-image             sample-test-crjch-2112996624  7m        
 | ├-✔ build-kubeflow-deployer-image        sample-test-crjch-3714949502  12m       
 | ├-✔ build-kubeflow-dnntrainer-image      sample-test-crjch-420811627   11m       
 | ├-✔ build-local-confusion-matrix         sample-test-crjch-1952761834  15m       
 | └-✔ build-local-roc                      sample-test-crjch-3248480952  16m
@Ark-kun Ark-kun assigned gaoning777 and hongye-sun and unassigned Ark-kun Aug 13, 2019
@gaoning777
Copy link
Contributor

A lots of these images will be cleaned in favor of the new gcp components.

@snyk-bot snyk-bot mentioned this issue May 26, 2021
Open
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@jlewi @k8s-ci-robot
Cicd delete old prs (kubeflow#575)
65c84fd 
* Define a script to close obsolete PRs to update an application.

* In the event there are multiple PRs open to update a Kubeflow application
  we want to close the older PRs; so there is a single open PR updating
  the application to the newest code.

Related to kubeflow#571

* Define a script to close obsolete PRs to update an application.

* In the event there are multiple PRs open to update a Kubeflow application
  we want to close the older PRs; so there is a single open PR updating
  the application to the newest code.

  Related to kubeflow#571

* Setup a def namespace for use with apps-cd.

* Update update_kf_apps.py to close old PRs on each sync.

* Bake the source code into the docker image rather than using a wrapper
  script to sync the code from git.

  * Sync'ing the code from git became to difficult to reason about once
    we start splitting the source code across multiple repositories
    * We now depend on github/kubeflow/code-intelligence for utilities
      for working with GitHub Apps

    * Using a docker image also ensures we don't get broken suddenly when
      new changes are in place

    * In the future we could use github actions to automate updating the
      deployment on postsubmits

* Turn app-pipeline.template.yaml into a ConfigMap
  * This allows better versioning
  * We can rely on kustomize to create a configmap with a hash based on the
    contents
  * kustomize will then reference the config map using its hash. As
    a result a rolling update is triggered whenever the hash contents changes.
  * This makes it easier to handle rollous and updates.

Define a dev instance of the update KF apps infrastructure to facilitate development
  * Use profiles in skaffold.

  * update_kf_apps.py in dev uses a config map now to ubtain app-pipeline.template.yaml
    rather than fetching it from git

  * This makes it much easier to test changes in the dev instance

Fix a bunch of bugs preventing update_kf_apps.py from working
   * Update requirements.txt with a bunch of missing packages.
   * Fix some imports in update_kf_apps.py

  * Need to set resource requests for the build pods otherwise builds get
    CPU starved and take forever.

Miscellaneous

* Create a tool to copy secrets between namespaces from GCS

* Fix lint.

* Due to kubeflow#460 we need to disable pylint.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@fenglixa
feat(backend): Support loop pipelineruns of defining dictionaries par…
99e506c 
…ams (kubeflow#460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaoning777 gaoning777

@hongye-sun hongye-sun

Labels
area/components kind/feature priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ark-kun @gaoning777 @qimingj @vicaire @hongye-sun