Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate python based visualization #4643

Closed
Bobgy opened this issue Oct 20, 2020 · 8 comments
Closed

Deprecate python based visualization #4643

Bobgy opened this issue Oct 20, 2020 · 8 comments

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Oct 20, 2020

Some problems we are facing with python based visualization (https://www.kubeflow.org/docs/pipelines/sdk/python-based-visualizations/):

  • dependency management
    • we can only maintain one version of the python packages and it's a big cost syncing with external packages like tfx
    • we cannot expose ways to let users install their own dependencies or upgrade dependencies
  • editor support
    • we do not want to reimplement editor features like saving code etc in KFP UI
    • we cannot support autocompletion etc

Therefore, I'd want to deprecate python based visualization. I recommend fetching data via Kubeflow Pipelines SDK and visualizing from your own notebook instead, which gives you full control over your visualization process.

If you want some visualization to show for every run, you can run a component as part of your pipeline, the component should run the python visualization and expose HTML content of the visualization via https://www.kubeflow.org/docs/pipelines/sdk/output-viewer/#web-app.

@rmgogogo
Copy link
Contributor

+1

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 21, 2020

What this implies is that, the TFDV/TFMA auto visualizations should be components in the golden tfx pipeline sample.
Further explained in #3510

@rmgogogo
Copy link
Contributor

What this implies is that, the TFDV/TFMA auto visualizations should be components in the golden tfx pipeline sample.

I personally OK with it, especially considering current e2e experiences.
@IronPan @james-jwu for review.

@stale
Copy link

stale bot commented Jan 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jan 20, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 1, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Feb 1, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 5, 2021

Blocker is to build a new way to visualize for tfx pipelines in #3970

@rimolive
Copy link
Member

Closing this issue. #3970 is closed.

/close

Copy link

@rimolive: Closing this issue.

In response to this:

Closing this issue. #3970 is closed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

No branches or pull requests

4 participants