Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logical operators in conditions (and, or, not) #482

Closed
Ark-kun opened this issue Dec 5, 2018 · 10 comments
Closed

Support logical operators in conditions (and, or, not) #482

Ark-kun opened this issue Dec 5, 2018 · 10 comments

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 5, 2018

No description provided.

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

What is the status on this?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 29, 2019

What is the status on this?

Not implemented yet.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 29, 2019

I hear no user requests fro this feature. It's not that hard to implement, but not trivial either (needs to build and traverse the logical expression graph).

@gaoning777
Copy link
Contributor

Workaround or simple '&&' and '||' is possible with the current conditions. For example, users can write two conditions(one in another one) to represent the '&&' logic.

@Ark-kun Ark-kun added the help wanted The community is welcome to contribute. label Aug 14, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 26, 2019

@gaoning777
Copy link
Contributor

/unassign @gaoning777

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
…low#482)

Updated test case too since now we just need check there's runtime error
Copy link

@dkletran: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dkletran
Copy link

dkletran commented Nov 8, 2024

We are currently using KFP Pipelines v2, and the conditional branching options with dsl.If, dsl.Elif, and dsl.Else are not sufficient for our needs. The ability to combine conditions logically is essential for us, and we are currently patching KFP compiling code to achieve this functionality. It would be very helpful to have this feature available in Kubeflow Pipelines.

Could this issue be reopened, or would it be better to create a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants