-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image substitution feature to either DSL compiler or KFP client #487
Comments
The name is currently substituted during the compilation stage. |
That is a different issue. This issue is about replacing |
I understand the usefulness of the image replacement but I'm leaning towards supporting the image replacement by the user. It is simply one sed bash command. WDYT? |
|
JFYI, The current DSL compiler already supports substituting images with runtime PipelineParam. |
@Ark-kun I'm gonna close this issue now. Feel free to reopen this if you think otherwise. |
…kubeflow#487) * See kubeflow/kfctl#58 junit artifacts aren't being uploaded for some of our tests because the GCS bucket is being set incorrectly. * It looks like the problem is that our Argo workflows are setting BUILD_ID and not BUILD_NUMBER * To avoid breaking workflows that might still be relying on BUILD_NUMBER we try BUILD_ID and fall back to BUILD_NUMBER
* add configuration for tekton pipeline spec * sort annotation order
We need a way to properly perform container image substitution.
The substitution can be performed either during the pipeline compilation or before the run submission. (It can also be performed in the backend.)
run = client.run_pipeline(exp.id, 'my-tfx', 'my-tfx.tar.gz', params={}, image_substitution_map={'gcr.io/old-image': 'gcr.io/new-image'})
The text was updated successfully, but these errors were encountered: