Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata for ibm components targeting opensource #1071

Merged
merged 1 commit into from
Apr 3, 2019
Merged

metadata for ibm components targeting opensource #1071

merged 1 commit into from
Apr 3, 2019

Conversation

animeshsingh
Copy link
Contributor

@animeshsingh animeshsingh commented Apr 1, 2019 •
edited by jlewi
Loading

Adding metadata initial description for components targeting ibm opensource

This change is Reviewable

@Tomcli
Copy link
Member

Tomcli commented Apr 2, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Tomcli: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@Tomcli: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@animeshsingh
Copy link
Contributor Author

@jlewi can you take a look at this - given that @Tomcli is in OWNERS file of top-level directory- why doesn`t it get routed to him, or why cannot he approve this?

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 3, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c0558e into kubeflow:master Apr 3, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@salanki
Add salanki as reviewer (kubeflow#1071)
67e3d1a
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@yhwang
update toolchain image (kubeflow#1071)
880f37e 
update pkg, utilities, commands to newer version, including:
- base image ubuntu:20.04
- kubectl 1.25.3
- ibmcloud
- node 18.6
- go v1.19.2

Signed-off-by: Yihong Wang <[email protected]>

Signed-off-by: Yihong Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Ark-kun Ark-kun

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@animeshsingh @Tomcli @k8s-ci-robot @Ark-kun