-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade node to v18 #10794
chore: upgrade node to v18 #10794
Conversation
Signed-off-by: Humair Khan <[email protected]>
@HumairAK: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test kubeflow-pipeline-frontend-test |
cc @chensun / @zijianjoy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Are there any plans of backporting this to a specific release/version? |
Description of your changes:
Resolves: #10770
Furthers: #10777
Note while node 18 is still in maintenance, this is not the latest 18.x release, which is 18.20.2 as of this writing. I was encountering issues with 18.19 and 18.20, so I settled for 18.18 to resolve the current build issues. But we update to the latest as a follow up.
@craco/craco
also needed a minor version bump, and package-lock.json was updated vianpm i --package-lock-only
, with the following env:I'm not well versed in frontend so if this is not the right way, let me know and I can update it.
Checklist: