Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated descriptions of pre-installed samples #1126

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 10, 2019

Removed the "Basic - Immediate Value" sample since it does not really serve any purpose - other samples also feature hard-coded arguments.


This change is Reviewable

Removed the "Basic - Immediate Value" sample since it does not really serve any purpose - other samples also feature hard-coded arguments.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 10, 2019

/test kubeflow-pipeline-e2e-test

Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@IronPan
Copy link
Member

IronPan commented Apr 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 584d31f into kubeflow:master Apr 11, 2019
@Ark-kun Ark-kun deleted the Updated-descriptions-of-pre-installed-samples branch April 22, 2019 21:23
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants