-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): turn off GKE metadata by default #11321
base: master
Are you sure you want to change the base?
fix(ui): turn off GKE metadata by default #11321
Conversation
Since GKE is only one of many platforms, change the default value of `DISABLE_GKE_METADATA` to `true`. Edit the gcp manifest to override that to `false` on GCP. Fixes: kubeflow#11247 Signed-off-by: Greg Sheremeta <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the frontend failures here are relevant: Details
so we'd need to address those somehow |
Description of your changes:
Since GKE is only one of many platforms, change the default value of
DISABLE_GKE_METADATA
totrue
. Edit the gcp manifest to override that tofalse
on GCP.Fixes: #11247
Checklist: