Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): turn off GKE metadata by default #11321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregsheremeta
Copy link
Contributor

Description of your changes:

Since GKE is only one of many platforms, change the default value of DISABLE_GKE_METADATA to true. Edit the gcp manifest to override that to false on GCP.

Fixes: #11247

Checklist:

Since GKE is only one of many platforms, change the default value
of `DISABLE_GKE_METADATA` to `true`. Edit the gcp manifest to override
that to `false` on GCP.

Fixes: kubeflow#11247

Signed-off-by: Greg Sheremeta <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Collaborator

HumairAK commented Oct 22, 2024

the frontend failures here are relevant:

Details

 FAIL ./app.test.ts
  ● Console

    console.log integration-tests/test-helper.ts:1867
      beforeAll, writing files
    console.info node_modules/http-proxy-middleware/lib/logger.js:81
      [HPM] Proxy created: /  ->  http://localhost:9090

  ● UIServer apis › /system › /cluster-name › responds with cluster name data from gke metadata

    expected 200 "OK", got 500 "Internal Server Error"

      at Test._assertStatus (node_modules/supertest/lib/test.js:268:12)
      at Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.assert (node_modules/supertest/lib/test.js:173:18)
      at localAssert (node_modules/supertest/lib/test.js:131:12)
      at node_modules/supertest/lib/test.js:128:5
      at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3)
      at IncomingMessage.<anonymous> (node_modules/superagent/lib/node/index.js:916:18)

  ● UIServer apis › /system › /cluster-name › responds with 500 status code if corresponding endpoint is not ok

    expected 'Failed fetching GKE cluster name' response body, got 'GKE metadata endpoints are disabled.'

      at error (node_modules/supertest/lib/test.js:301:13)
      at Test._assertBody (node_modules/supertest/lib/test.js:218:14)
      at Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.assert (node_modules/supertest/lib/test.js:173:18)
      at localAssert (node_modules/supertest/lib/test.js:131:12)
      at node_modules/supertest/lib/test.js:128:5
      at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3)
      at IncomingMessage.<anonymous> (node_modules/superagent/lib/node/index.js:916:18)

  ● UIServer apis › /system › /project-id › responds with project id data from gke metadata

    expected 200 "OK", got 500 "Internal Server Error"

      at Test._assertStatus (node_modules/supertest/lib/test.js:268:12)
      at Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.assert (node_modules/supertest/lib/test.js:173:18)
      at localAssert (node_modules/supertest/lib/test.js:131:12)
      at node_modules/supertest/lib/test.js:128:5
      at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3)
      at IncomingMessage.<anonymous> (node_modules/superagent/lib/node/index.js:916:18)

  ● UIServer apis › /system › /project-id › responds with 500 status code if metadata request is not ok

    expected 'Failed fetching GKE project id' response body, got 'GKE metadata endpoints are disabled.'

      at error (node_modules/supertest/lib/test.js:301:13)
      at Test._assertBody (node_modules/supertest/lib/test.js:218:14)
      at Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.assert (node_modules/supertest/lib/test.js:173:18)
      at localAssert (node_modules/supertest/lib/test.js:131:12)
      at node_modules/supertest/lib/test.js:128:5
      at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3)
      at IncomingMessage.<anonymous> (node_modules/superagent/lib/node/index.js:916:18)

so we'd need to address those somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ml-pipeline-ui failing on metadata api
2 participants