Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Compiler - Preventing pipeline entrypoint template name from clashing with other template names #1555

Merged
merged 1 commit into from
Dec 6, 2019
Merged

SDK/Compiler - Preventing pipeline entrypoint template name from clashing with other template names #1555

merged 1 commit into from
Dec 6, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 25, 2019 •
edited
Loading

Fixes #428
Case exhibiting the problem:

def some_name():
    dsl.ContainerOp(
        name='some_name',
        image='alpine:latest',
    )
kfp.compiler.Compiler().compile(some_name)

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 27, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
SDK/Compiler - Preventing pipeline entrypoint template name from clas…
5f6b165 
…hing with other template names

Case exhibiting the problem:
```
def add(a, b):
    ...
@dsl.pipeline(name="add')
def some_name():
    add(...)
```
@Ark-kun Ark-kun force-pushed the SDK---Preventing-pipeline-entrypoint-template-name-from-clashing-with-other-template-names branch from fa29d4f to 5f6b165 Compare November 25, 2019 07:25
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 4, 2019

/test kubeflow-pipeline-frontend-test

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b8a2e6f into master Dec 6, 2019
@Ark-kun Ark-kun mentioned this pull request Jan 16, 2020
Closed
@Ark-kun Ark-kun mentioned this pull request Feb 6, 2020
Closed
@Bobgy Bobgy deleted the SDK---Preventing-pipeline-entrypoint-template-name-from-clashing-with-other-template-names branch June 17, 2020 02:17
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@pvaneck
Update OpenShift documentation (kubeflow#1555)
2c58576 
Update versions and path, and add a troubleshooting section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@kevinbache kevinbache Awaiting requested review from kevinbache

Assignees

@numerology numerology

Labels
approved area/sdk/dsl/compiler lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSL compilation fails when pipeline has op with the same name as the pipeline itself
4 participants
@Ark-kun @numerology @k8s-ci-robot @kevinbache