Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog 0.1.25 #1695

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Changelog 0.1.25 #1695

merged 6 commits into from
Jul 31, 2019

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Jul 29, 2019

This change log is generated when 0.1.25 tag is bound to commit a16f380


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 29, 2019

Can you please only add the part for 1.25 without removing the history?

@jingzhang36
Copy link
Contributor Author

jingzhang36 commented Jul 29, 2019

Can you please only add the part for 1.25 without removing the history?

Not quite sure why the removal of old entries happened. The PR is auto-generated by changelog tool.... Any idea why?

---edit
Talked to Yang offline and figured it out. Going to revise the PR...

@jingzhang36
Copy link
Contributor Author

Done with fix. Only 0.1.25 new entries are added. Previous changes are not touched.
/assign @IronPan
/assign @Ark-kun

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 30, 2019

/lgtm

@IronPan
Copy link
Member

IronPan commented Jul 31, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan IronPan merged commit 3dc73ba into master Jul 31, 2019
@IronPan IronPan deleted the changelog_0125 branch July 31, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants