Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated argo install instruction #1719

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Remove outdated argo install instruction #1719

merged 1 commit into from
Aug 13, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Aug 2, 2019 •
edited by jlewi
Loading

@Bobgy Bobgy changed the title Remove outdated argo install instruction [WIP] Remove outdated argo install instruction Aug 2, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 2, 2019

These were not the only issues. This doc is completely out-dated.

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 3, 2019

/lgtm

@Ark-kun Ark-kun assigned IronPan and unassigned Ark-kun Aug 9, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 9, 2019

@Bobgy Is this PR still WIP?

@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 9, 2019

@Ark-kun I realized this is not the only issue with this README.md. It's outdated in much more ways. So I held this PR back until I figured out more.

I will put other changes in new PRs. This one is good enough just with these.

@Bobgy Bobgy changed the title [WIP] Remove outdated argo install instruction Remove outdated argo install instruction Aug 9, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 10, 2019

/retest kubeflow-pipeline-e2e-test

1 similar comment
@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 13, 2019

/retest kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 13, 2019

/test kubeflow-pipeline-e2e-test

1 similar comment
@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 13, 2019

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 13, 2019

/test kubeflow-pipeline-e2e-test

1 similar comment
@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 13, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit af1e0ee into kubeflow:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@IronPan IronPan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bobgy @Ark-kun @k8s-ci-robot @IronPan