Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce taxi and xgboost test data to speed up sample test #1917

Merged
merged 1 commit into from
Aug 28, 2019
Merged

reduce taxi and xgboost test data to speed up sample test #1917

merged 1 commit into from
Aug 28, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Aug 21, 2019 •
edited by jlewi
Loading

This change is Reviewable

numerology
numerology approved these changes Aug 21, 2019
View reviewed changes
Copy link

@numerology numerology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Are you willing to clean up the old csv, too? Thanks.

@gaoning777
Copy link
Contributor Author

For sure. I was waiting for the tests to pass before cleaning those up, thus making sure the smaller size does not affect correctness.

@numerology
Copy link

Seems like we need a sample set big enough to include both pos and neg samples so that roc_curve can work. @gaoning777

@gaoning777
Copy link
Contributor Author

Seems like we need a sample set big enough to include both pos and neg samples so that roc_curve can work. @gaoning777

You are correct. Closing this.

@gaoning777 gaoning777 closed this Aug 23, 2019
@numerology
Copy link

How do you like the idea of hard coding one must-be-positive sample so that the roc_curve is defined?

@gaoning777 gaoning777 reopened this Aug 27, 2019
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 03143cf into kubeflow:master Aug 28, 2019
@gaoning777 gaoning777 deleted the decrease-xgboost-time branch August 28, 2019 01:32
ajchili pushed a commit to ajchili/pipelines that referenced this pull request Aug 28, 2019
@gaoning777 @ajchili
reduce taxi and xgboost test data to speed up sample test (kubeflow#1917
2aacc08 
)
@VaniHaripriya VaniHaripriya mentioned this pull request Oct 15, 2024
Open
@HumairAK HumairAK mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numerology numerology numerology approved these changes

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@numerology numerology

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaoning777 @numerology @k8s-ci-robot