Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend support for Python based visualizations #1959

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Aug 27, 2019

Waiting on #1951 to be merged and for bug to be fixed. Encountered bug results in incorrect visualizations being rendered when changing selected component.


This change is Reviewable

Most work on feature is completed. Currently attempting to fix bug where UI does not properly render visualizations for selected component.
@ajchili ajchili force-pushed the ajchili/add-frontend-support-for-python-based-visualizations branch from b990991 to 4b432a2 Compare August 28, 2019 18:17
@ajchili ajchili changed the title [WIP] Add frontend support for Python based visualizations Add frontend support for Python based visualizations Aug 28, 2019
@ajchili
Copy link
Member Author

ajchili commented Aug 28, 2019

/hold
Waiting for Python service PRs to be merged first.

Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests should be added ASAP
/lgtm
/approve

frontend/src/pages/RunDetails.tsx Outdated Show resolved Hide resolved
frontend/src/pages/RunDetails.tsx Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 29, 2019
@ajchili
Copy link
Member Author

ajchili commented Aug 29, 2019

/hold cancel

Copy link
Contributor

@neuromage neuromage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of minor comments.

frontend/src/lib/Apis.ts Outdated Show resolved Hide resolved
@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage, rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c5d2f68 into kubeflow:master Aug 29, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* updated istio download url

Signed-off-by: Suresh Nakkeran <[email protected]>

* update boto3 to 1.20.24

Signed-off-by: Dan Sun <[email protected]>

Co-authored-by: Dan Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants