-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frontend support for Python based visualizations #1959
Add frontend support for Python based visualizations #1959
Conversation
…ns in artifacts tab
b990991
to
4b432a2
Compare
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tests should be added ASAP
/lgtm
/approve
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Couple of minor comments.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage, rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* updated istio download url Signed-off-by: Suresh Nakkeran <[email protected]> * update boto3 to 1.20.24 Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Dan Sun <[email protected]>
Waiting on #1951 to be merged and for bug to be fixed. Encountered bug results in incorrect visualizations being rendered when changing selected component.
This change is