Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the unnecessary trunk when generating the DB name #2151

Merged
merged 8 commits into from
Sep 18, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Sep 18, 2019

The marketplace app name can never exceed 32 char. Remove the trunk to improve code readability.

/assign @rmgogogo


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Sep 18, 2019

/test kubeflow-pipeline-sample-test

@k8s-ci-robot
Copy link
Contributor

@IronPan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-sample-test 1703c34 link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rmgogogo
Copy link
Contributor

"The marketplace app name can never exceed 32 char. Remove the trunk... "
Didn't understand why you mention app name limitation but here is DB name. Anyway, LGTM

@rmgogogo
Copy link
Contributor

/lgtm

@rmgogogo
Copy link
Contributor

Got it, saw you also remove trunk for release name.

@IronPan
Copy link
Member Author

IronPan commented Sep 18, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Sep 18, 2019

test failures not related to the change

@IronPan IronPan merged commit 0971006 into kubeflow:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants