Upgrade @kubernetes/client-node #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any particular motivation here? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The frontend tests seem to be super-flaky today ... |
|
Yes. My guess is it's 790cb36. |
|
/test presubmit-e2e-test |
3 similar comments
|
/test presubmit-e2e-test |
|
/test presubmit-e2e-test |
|
/test presubmit-e2e-test |
yebrahim
force-pushed
the
yebrahim/patch-4
branch
from
563fb4c
to
2939ee0
Compare
|
/lgtm |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* ksonnet utilities for testing.
* Create a new module ks_util for common utilities related to ksonnet.
* Move the function get_ksonnet_cmd from run_e2e_workflow.py into ks_util
* We want to reuse this function e.g. to submit TFJobs as part of E2E
testing.
* Move setup_ks_app from
https://github.com/kubeflow/tf-operator/blob/master/py/ks_util.py
so it can be reused by other tests not just tf-operator.
* Fix.
* Update setup_ks_app to use the new command.
* Add missing yaml import.
* Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is