Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Standalone] Fix GCP cloudsql manifest #2772

Merged
merged 1 commit into from
Dec 25, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Dec 25, 2019

Fixes #2719

Decisions

Verification

$ kubectl kustomize env/gcp/ | grep workflow-controller-configmap -C 30
    component: metadata-server
  name: metadata-mysql-configmap
  namespace: kubeflow
---
apiVersion: v1
data:
  config: |
    {
    namespace: kubeflow,
    executorImage: gcr.io/ml-pipeline/argoexec:v2.3.0-license-compliance,
    artifactRepository:
    {
        s3: {
            bucket: '', # Replace this with the same bucket as OBJECTSTORECONFIG_BUCKETNAME.
            keyPrefix: artifacts,
            endpoint: minio-service.kubeflow:9000,
            insecure: true,
            accessKeySecret: {
                name: mlpipeline-minio-artifact,
                key: accesskey
            },
            secretKeySecret: {
                name: mlpipeline-minio-artifact,
                key: secretkey
            }
        }
    }
    }
kind: ConfigMap
metadata:
  name: workflow-controller-configmap
  namespace: kubeflow
---

namespace replacement works well too


This change is Reviewable

@Bobgy Bobgy changed the title Fix GCP cloudsql manifest [Standalone] Fix GCP cloudsql manifest Dec 25, 2019
@jingzhang36
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 840979c into kubeflow:master Dec 25, 2019
@Bobgy Bobgy deleted the gcp_cloud_sql_fix branch December 25, 2019 09:42
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to save output artifacts into GCS
3 participants