Add run status to page title #287
Conversation
|
/approve |
|
/lgtm |
Oh no. Reducing the coverage is not good. |
|
Modified the coverall settings to disable this for now (looks like it is enabled by default). Let me know if you still have an issue. |
|
Any ideas what needs to be done here? It's still stuck on coveralls. |
|
I am guessing that coverall needs to run again. You could try a small
change to run it again.
…On Mon, Nov 19, 2018 at 10:54 Yasser Elsayed ***@***.***> wrote:
Any ideas what needs to be done here? It's still stuck on coveralls.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#287 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYkFTSmyB-JuIM9C4J9yZh4eD0sVc0llks5uwv5jgaJpZM4YixXa>
.
|
yebrahim
force-pushed
the
yebrahim/page-title
branch
from
c34b6ce
to
d3ad12b
Compare
|
Done. Can you add back an lgtm please? Thanks. |
|
/lgtm
…On Mon, Nov 19, 2018 at 11:01 Yasser Elsayed ***@***.***> wrote:
Done. Can you add back an lgtm please? Thanks.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#287 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYkFTdTDCKUdmFZzT7h4yri-UOJFJ1ibks5uwwAegaJpZM4YixXa>
.
|
|
/test build-image |
yebrahim
force-pushed
the
yebrahim/page-title
branch
from
d3ad12b
to
3d4e5b0
Compare
yebrahim
changed the title
yebrahim
force-pushed
the
yebrahim/page-title
branch
from
da45134
to
d7b7d2f
Compare
yebrahim
force-pushed
the
yebrahim/page-title
branch
from
d7b7d2f
to
016f27b
Compare
yebrahim
force-pushed
the
yebrahim/page-title
branch
from
016f27b
to
8cdbaf1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yebrahim
changed the title
|
/lgtm |
* First commit to cronjob Dockerfile * First commit of workflows.sh * First commit of checkout * Add deps to Dockerfile * Add Pipfile * change naming * simple checkout lib * print out /src * Add ENTRYPOINT * First commit to cronjob config * fix indent * Fix git clone in checkout * change deploy-worker tag to latest * Link to create_kf_instance * Add temp config to use gabrielwen-learning * Use gcloud to check permission * activate service account auth * extend interval to 20min for now * Add toto * changes * Move deployment clean up to create_kf_instance * Move kubeconfig file init to create_kf_instance * Update to cronjob spec * Rename folder * Remove local settings * Add todo * add todo * chmod a+x to checkout.sh and workflows.sh * change kfctl version * use fresh copy from git repo * remove local checkout * change pythonpath
updateToolbaraccept a partial object of toolbar props.pageTitleproperty to toolbar props that accepts a string or a component.This change is