Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable tfdv, remove hardcode as a sample for following PRs #3089

Merged
merged 1 commit into from
Feb 17, 2020
Merged

enable tfdv, remove hardcode as a sample for following PRs #3089

merged 1 commit into from
Feb 17, 2020

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Feb 14, 2020 •
edited by jlewi
Loading

This change is Reviewable

rmgogogo
rmgogogo commented Feb 14, 2020
View reviewed changes
backend/src/apiserver/visualization/types/tfdv.py

tfdv.visualize_statistics(train_stats)
def get_statistics_html(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after TFDV fix got release, here it can be reverted and may move to a new type e.x. tfdvstats.py

rmgogogo
rmgogogo commented Feb 14, 2020
View reviewed changes
backend/src/apiserver/visualization/types/tfdv.py

stats = tfdv.load_statistics(source)
html = get_statistics_html(stats)
display(HTML(html))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingzhang36 you can try this way for TFMA. Essentially it just output htmls.
Putting Python codes in frontend side would make many troubles, please move to new typed visualization

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d0ef0ae into kubeflow:master Feb 17, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Feb 17, 2020

@rmgogogo Thanks for the quick turn around!

@Bobgy Bobgy mentioned this pull request Feb 26, 2020
Closed
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@rmgogogo @Jeffwan
enable tfdv, remove hardcode as a sample for following PRs (kubeflow#…
9d05f5f 
…3089)

Co-authored-by: renmingu <[email protected]>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@andyi2it
Check sys platform before using SIGQUIT - fix windows development (ku…
2f5b778 
…beflow#3089)

Signed-off-by: Andrews Arokiam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@neuromage neuromage Awaiting requested review from neuromage

Assignees
No one assigned
Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmgogogo @k8s-ci-robot @Bobgy