SDK/DSL - Added support for conditions: !=, <, <=, >=, > #309
Conversation
Ark-kun
force-pushed
the
avolkov/SDK/DSL---Added-support-for-5-more-conditional-operations
branch
from
99e72a6
to
8f450ad
Compare
Ark-kun
changed the title
Ark-kun
force-pushed
the
avolkov/SDK/DSL---Added-support-for-5-more-conditional-operations
branch
from
8f450ad
to
9b387f8
Compare
There was a problem hiding this comment.
Can you add a few tests under https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/_ops_group.py#L81?
Also, can you modify the samples/basic/condition.py, so that it covers '==' and a different one? That will give users a good start.
|
Agree with @qimingj on adding tests and updating samples |
|
Tracking the request for condition tests here: #436 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
avolkov/SDK/DSL---Added-support-for-5-more-conditional-operations
branch
…ubeflow#309) * We upgraded the test cluster to use the new stackdriver monitoring to make it easier to monitor Kubeflow. * This PR updates the readme to provide instructions on how to leverage that. * Fix kubeflow#177
* add readme for azure * add blob tests * fix typo * fix and add moar tests * add another case * make linter happy
* Remove persistentVolumeClaim by volumeClaimTemplate * address the comments from tomcli
This change is