return self for container op initialization methods to allow chaining the construction #313
Conversation
|
/assign @Ark-kun |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -36,11 +36,11 @@ def test_operator_to_template(self): | |||
| msg2 = dsl.PipelineParam('msg2', value='value2') | |||
| op = dsl.ContainerOp(name='echo', image='image', command=['sh', '-c'], | |||
| arguments=['echo %s %s | tee /tmp/message.txt' % (msg1, msg2)], | |||
| file_outputs={'merged': '/tmp/message.txt'}) | |||
| op.add_volume_mount(k8s_client.V1VolumeMount( | |||
| file_outputs={'merged': '/tmp/message.txt'}). \ | |||
There was a problem hiding this comment.
Nit: It might look better if you move the dot to the next line (here and everywhere).
|
/lgtm |
|
/assign @gaoning777 |
|
/lgtm |
* take snapshot with branch names * checkout with branch * add head cron yaml * update args * add deploy-cron-v0-4.yaml * remove comment * add comment * rename
Please see test cases for examples how this would look like.
This change is