Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an optional name for dsl.Condition (kubeflow#3210) #3212

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

xiaohanhuang
Copy link
Contributor

@xiaohanhuang xiaohanhuang commented Mar 4, 2020

This change is Reviewable

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @xiaohanhuang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiaohanhuang
Copy link
Contributor Author

xiaohanhuang commented Mar 4, 2020

Don't know why the CLA didn't work, all my information is correct now.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@xiaohanhuang
Copy link
Contributor Author

/assign @gaoning777

@numerology
Copy link

Thanks! @xiaohanhuang do you mind adding some tests for this?

@numerology
Copy link

/ok-to-test

@numerology
Copy link

/unassign @gaoning777
/assign @numerology

@k8s-ci-robot k8s-ci-robot assigned numerology and unassigned gaoning777 Mar 4, 2020
@xiaohanhuang
Copy link
Contributor Author

Thanks! @xiaohanhuang do you mind adding some tests for this?
Added tests

@numerology
Copy link

/retest

@numerology
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e704067 into kubeflow:master Mar 6, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* add an optional name for dsl.Condition (kubeflow#3210)

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants