Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed the sample tests when it should #417

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 29, 2018

This change is Reviewable

@gaoning777
Copy link
Contributor Author

/test presubmit-sample-test

@gaoning777 gaoning777 changed the title [WIP] failed the sample tests when it should Failed the sample tests when it should Nov 30, 2018
@IronPan
Copy link
Member

IronPan commented Nov 30, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 548a2d6 into master Nov 30, 2018
@gaoning777 gaoning777 deleted the ngao/sample-test-v2 branch February 8, 2019 18:26
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
point to any sequencer design, and correct some verbiage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants