Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tfx version to 0.26.0 in backend #5052

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

zijianjoy
Copy link
Collaborator

Description of your changes:
As the recent update of python 3.7 to fix presubmit tests #5033, upgrade the backend dependencies to be compatible with new python version. The workable solution is to use tfx 0.26.0.

Checklist:

@chensun
Copy link
Member

chensun commented Jan 28, 2021

/approve

Wait for @numerology to take a look and LGTM.

@numerology, a question for you, Per this README, it looks like this dependency is only for visualization server? If that's the case, should we merge this requirements.* with the ones under https://github.com/kubeflow/pipelines/tree/master/backend/src/apiserver/visualization?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link

/lgtm

Thanks!
@chensun this requirements file is actually for the pre-baked sample, which is built into our backend docker image. See

# Compiling the preloaded samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants