-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Renovate #5056
Configure Renovate #5056
Conversation
Hi @renovate-bot. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@davidspek I think you've already been experimenting with a config for this repo? Feel free to @ me to review it before merging |
@rarkins @Bobgy This is what I had so far:
Notice, I specifically set |
Grouping the docker updates should maybe be configured for patch updates only, as minor updates will need specific folder rules. |
Anything automerge-related won't be possible (e.g. If you commit your |
Some early comments I'd suggest adding experience maintaining this repo: we should disable dockerfile upgrade for everything in our kustomize manifests and non-language third party images, because Google has strict license compliance requirements and we need to update their license files during an upgrade, that cannot be automated by renovate bot (therefore, is it possible to only turn on the dashboard feature for them?). still looking at the documentation |
0c2f764
to
92a3eba
Compare
92a3eba
to
3753a44
Compare
I'll iterate on the config a few times to remove all files we do not want to auto update. |
Co-authored-by: Rhys Arkins <[email protected]>
@renovate-bot rescan |
It should, but each new commit will cause any existing run to abort until the next run. It takes quite a while to scan the repo |
@rarkins @davidspek Thanks for introducing the tool. I have some questions regarding the Python dependency updates.
|
|
BTW I can't comment specifically on your dependencies like |
While we are on the topic of python dependencies. I think it is worth the effort to go through all the Dockerfiles and remove any |
I can understand that, the best way to integrate with a tool is moving your source of truth to it... thus we will need to manage all versions in renovate package rules. Is there a less intrusive way to integrate? The approach is similar to package.json and package-lock.json, is there a similar workflow we can use in python that is compatible with renovate? EDIT: I found it, looks like renovate bot has native support for python-poetry: https://docs.renovatebot.com/modules/manager/poetry/. Poetry is a package manager like npm for python. Maybe we should consider poetry instead. Note, all these discussion do not need to block the configuration PR, because python dependencies were disabled from auto-upgrade in the config. |
@davidspek that's a good point! Would you mind creating an issue to track it? |
@Bobgy I will create a PR for it once I have figured out why I can't get an image to start services with the s6 overlay :). |
@rarkins, thanks for explaining this. So if I understand correctly, the bot doesn't have a dependency resolver. All it does is to look at requirements.txt and update each entry with the latest minor release. It doesn't really care if the packages are compatible (theoretically minor version update shouldn't break compatibility). Am I right? The reason I mentioned pip is kinda special, but there might be cases we do want to choose a minor version as an upper constraint. For instance, during the early development phase, we may want to reserve Line 41 in c5c8d71
In general, I agree. I thought that |
/ok-to-test |
For Python, the source of truth of dependency should probably be the
While I don't use the
For alternatives, I recently started using pipenv in a personal project. It's probably closer to "package.json and package-lock.json" as you mentioned with "Pipfile and Pipfile.lock". It also supports virtual env which is nice. That said, I'm still new to this tool, this comment is not a recommendation of switching to it in KFP.
That's fine. We can experiment with this tool and see how it works. |
/lgtm |
Thanks, we can continue the python dependency discussion in related issues. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, renovate-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, renovate-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Renovate is disabledRenovate is disabled due to lack of config. If you wish to reenable it, you can either (a) commit a config file to your base branch, or (b) rename this closed PR to trigger a replacement onboarding PR. |
Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.
Detected Package Files
WORKSPACE
(bazel)backend/Dockerfile
(dockerfile)backend/Dockerfile.bazel
(dockerfile)backend/Dockerfile.cacheserver
(dockerfile)backend/Dockerfile.persistenceagent
(dockerfile)backend/Dockerfile.scheduledworkflow
(dockerfile)backend/Dockerfile.viewercontroller
(dockerfile)backend/Dockerfile.visualization
(dockerfile)backend/metadata_writer/Dockerfile
(dockerfile)backend/src/cache/deployer/Dockerfile
(dockerfile)components/gcp/container/Dockerfile
(dockerfile)components/kubeflow/deployer/Dockerfile
(dockerfile)components/kubeflow/dnntrainer/Dockerfile
(dockerfile)components/kubeflow/katib-launcher/Dockerfile
(dockerfile)components/kubeflow/kfserving/Dockerfile
(dockerfile)components/kubeflow/launcher/Dockerfile
(dockerfile)components/local/base/Dockerfile
(dockerfile)components/local/confusion_matrix/Dockerfile
(dockerfile)components/local/roc/Dockerfile
(dockerfile)components/sample/keras/train_classifier/Dockerfile
(dockerfile)contrib/components/openvino/model_convert/containers/Dockerfile
(dockerfile)contrib/components/openvino/ovms-deployer/containers/Dockerfile
(dockerfile)contrib/components/openvino/predict/containers/Dockerfile
(dockerfile)contrib/components/openvino/tf-slim/containers/Dockerfile
(dockerfile)frontend/Dockerfile
(dockerfile)manifests/gcp_marketplace/deployer/Dockerfile
(dockerfile)proxy/Dockerfile
(dockerfile)samples/contrib/image-captioning-gcp/src/Dockerfile
(dockerfile)samples/contrib/nvidia-resnet/components/inference_server_launcher/Dockerfile
(dockerfile)samples/contrib/nvidia-resnet/components/preprocess/Dockerfile
(dockerfile)samples/contrib/nvidia-resnet/components/train/Dockerfile
(dockerfile)samples/contrib/nvidia-resnet/components/webapp/Dockerfile
(dockerfile)samples/contrib/nvidia-resnet/components/webapp_launcher/Dockerfile
(dockerfile)samples/contrib/nvidia-resnet/pipeline/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/helloworld-ci-sample/helloworld/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/download_dataset/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/submit_result/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/train_model/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/visualize_html/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/visualize_table/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/mnist-ci-sample/tensorboard/Dockerfile
(dockerfile)samples/contrib/versioned-pipeline-ci-samples/mnist-ci-sample/train/Dockerfile
(dockerfile)test/api-integration-test/Dockerfile
(dockerfile)test/frontend-integration-test/Dockerfile
(dockerfile)test/frontend-integration-test/selenium-standalone-chrome-gcloud-nodejs.Docker/Dockerfile
(dockerfile)test/imagebuilder/Dockerfile
(dockerfile)test/images/Dockerfile
(dockerfile)test/initialization-test/Dockerfile
(dockerfile)test/sample-test/Dockerfile
(dockerfile)tools/bazel_builder/Dockerfile
(dockerfile)go.mod
(gomod)frontend/mock-backend/package.json
(npm)frontend/package.json
(npm)frontend/server/package.json
(npm)package.json
(npm)test/frontend-integration-test/package.json
(npm)frontend/.nvmrc
(nvm)backend/metadata_writer/requirements.txt
(pip_requirements)backend/requirements.txt
(pip_requirements)backend/src/apiserver/visualization/requirements.txt
(pip_requirements)components/kubeflow/katib-launcher/requirements.txt
(pip_requirements)contrib/components/openvino/ovms-deployer/containers/requirements.txt
(pip_requirements)docs/requirements.txt
(pip_requirements)samples/contrib/azure-samples/databricks-pipelines/requirements.txt
(pip_requirements)samples/contrib/ibm-samples/ffdl-seldon/source/seldon-pytorch-serving-image/requirements.txt
(pip_requirements)samples/core/ai_platform/training/requirements.txt
(pip_requirements)samples/core/container_build/requirements.txt
(pip_requirements)sdk/python/requirements.txt
(pip_requirements)test/kfp-functional-test/requirements.txt
(pip_requirements)test/sample-test/requirements.txt
(pip_requirements)components/gcp/container/component_sdk/python/setup.py
(pip_setup)components/kubeflow/dnntrainer/src/setup.py
(pip_setup)samples/core/ai_platform/training/setup.py
(pip_setup)sdk/python/setup.py
(pip_setup)Configuration
🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.
Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.
What to Expect
With your current configuration, Renovate will create 57 Pull Requests:
chore(deps): pin dependencies
renovate/pin-dependencies
master
4.1.3
3.0.1
9.4.0
3.1.43
5.5.0
1.0.35
0.7.40
3.10.3
1.0.5
4.17.2
4.16.0
3.7.2
1.4.0
0.19.3
0.17.6
24.9.1
23.3.11
3.12.3
4.14.119
6.9.0
7.0.5
10.17.16
10.17.11
2.5.5
1.19.0
16.9.22
16.9.5
4.3.1
16.0.3
9.18.11
2.0.8
4.0.3
1.6.1
0.11.1
3.0.2
5.7.0
1.0.10
0.8.4
3.10.0
1.15.1
3.3.5
3.10.0
0.19.1
8.0.1
25.3.0
3.13.1
4.17.19
6.10.3
5.2.0
3.0.0
4.11.0
16.12.0
7.0.2
16.12.0
5.1.1
4.3.1
0.1.0
3.4.1
16.7.0
9.21.0
1.11.5
0.6.1
8.0.0
4.0.2
0.9.6
25.2.1
7.0.1
1.0.0-pre.32
5.20.1
1.18.0
3.8.2
3.7.5
2.0.4
0.2.2
0.4.4
0.6.4
4.14.4
3.6.1
chore(deps): update gcr.io/inverting-proxy/agent docker digest to 9817c74
renovate/docker-gcr.io-inverting-proxy-agent
master
sha256:9817c740a3705e4bf889e612c071686a8cb3cfcfe9ad191c570a295c37316ff0
chore(deps): update github.com/vividcortex/mysqlerr commit hash to 4c396ae
renovate/github.com-vividcortex-mysqlerr-digest
master
4c396ae82aacc60540048b4846438cec44a1c222
chore(deps): update golang.org/x/net commit hash to 5f4716e
renovate/golang.org-x-net-digest
master
5f4716e94777e714bc2fb3e3a44599cb40817aac
chore(deps): update google.golang.org/genproto commit hash to 646a494
renovate/google.golang.org-genproto-digest
master
646a494a81eaa116cb3e3978e5ac1278e35abfdd
chore(deps): update docker patch updates docker tags (patch)
renovate/docker-patch-docker-updates
master
1.13.15-stretch
2.0.4-py3
2.2.2
chore(deps): update go.mod dependencies (patch)
renovate/patch-go-mod-updates
master
v0.19.9
v0.19.26
v0.19.12
v0.19.13
v0.19.15
v1.4.3
v0.5.4
v1.1.5
v1.12.2
v1.9.16
v6.0.57
v1.28.1
v0.17.17
v0.17.17
v0.17.17
v0.17.17
v1.11.10
v0.5.14
fix(deps): update npm dependencies (patch)
renovate/patch-npm-updates
master
3.0.2
9.4.1
3.1.47
1.0.36
0.7.44
3.10.8
1.0.6
4.17.11
4.16.1
3.7.4
23.3.14
3.12.6
4.14.168
6.9.1
7.0.7
10.17.51
2.5.8
1.19.1
16.9.56
16.9.10
4.3.5
9.18.12
2.0.10
4.0.4
1.6.2
3.0.14
0.8.5
1.15.6
0.19.2
4.17.20
7.0.5
3.4.4
9.21.2
1.11.7
0.6.2
8.0.2
1.0.0
3.8.3
0.2.9
0.0.12
4.42.1
chore(deps): update alpine docker tag to v3.13
renovate/docker-alpine-3.x
master
3.13
chore(deps): update gcr.io/cloud-marketplace-tools/k8s/deployer_helm/onbuild docker tag to v0.10.10
renovate/docker-gcr.io-cloud-marketplace-tools-k8s-deployer_helm-onbuild-0.x
master
0.10.10
chore(deps): update go.mod dependencies (minor)
renovate/go-mod-updates
master
v2.2.1
v0.20.0
v0.20.1
v1.2.0
v1.16.0
v1.14.6
v1.9.0
v1.7.0
v1.7.1
v1.7.0
v0.38.0
v1.35.0
v2.4.0
v0.20.2
v0.20.2
v0.20.2
v0.20.2
v1.20.2
v0.8.1
chore(deps): update golang docker tag
renovate/docker-golang-1.x
master
1.15.7
1.15.7-alpine3.12
1.14.14-stretch
chore(deps): update node.js
renovate/node-12.x
master
12.20.1
12.20.1-alpine
chore(deps): update npm dependencies (minor)
renovate/npm-updates
master
4.7.0
^0.13.0
3.9.4
9.5.0
5.16.4
1.2.1
4.17.11
0.19.3
6.11.3
16.14.2
16.9.4
9.21.11
4.16.3
3.1.0
5.16.0
1.2.0
3.11.0
3.6.1
3.14.0
^0.21.0
0.21.0
25.5.4
3.14.1
6.11.4
16.14.0
16.14.0
16.14.0
9.22.3
0.8.1
25.5.1
1.1.1
3.9.7
2.1.0
4.46.0
3.9.0
chore(deps): update nvcr.io/nvidia/tensorflow docker tag to v19.10
renovate/docker-nvcr.io-nvidia-tensorflow-19.x
master
19.10-py3
chore(deps): update python docker tag to v3.9
renovate/docker-python-3.x
master
3.9-slim
3.9
chore(deps): update tensorflow/tensorflow docker tag
renovate/docker-tensorflow-tensorflow-2.x
master
2.2.2-py3
2.4.1
chore(deps): update dependency @testing-library/react to v11
renovate/testing-library-react-11.x
master
11.2.3
chore(deps): update dependency @types/jest to v26
renovate/jest-26.x
master
26.0.20
chore(deps): update dependency @types/react to v17
renovate/react-17.x
master
17.0.0
chore(deps): update dependency @types/react-dom to v17
renovate/react-dom-17.x
master
17.0.0
chore(deps): update dependency @types/react-router-dom to v5
renovate/react-router-dom-5.x
master
5.1.7
chore(deps): update dependency @types/react-test-renderer to v17
renovate/react-test-renderer-17.x
master
17.0.0
chore(deps): update dependency @types/tar-stream to v2
renovate/tar-stream-2.x
master
2.2.0
chore(deps): update dependency jest to v26
renovate/major-jest-monorepo
master
26.6.3
chore(deps): update dependency prettier to v2
renovate/prettier-2.x
master
2.2.1
2.1.6
chore(deps): update dependency react-scripts to v4
renovate/react-scripts-4.x
master
4.0.1
chore(deps): update dependency standard-version to v9
renovate/standard-version-9.x
master
9.1.0
chore(deps): update dependency supertest to v6
renovate/supertest-6.x
master
6.1.3
chore(deps): update dependency ts-jest to v26
renovate/ts-jest-26.x
master
26.5.0
chore(deps): update dependency ts-node to v9
renovate/ts-node-9.x
master
9.1.1
chore(deps): update dependency typescript to v4
renovate/typescript-4.x
master
4.1.3
chore(deps): update dependency webpack to v5
renovate/webpack-5.x
master
5.19.0
chore(deps): update dependency webpack-bundle-analyzer to v4
renovate/webpack-bundle-analyzer-4.x
master
4.4.0
chore(deps): update module argoproj/argo to v2
renovate/github.com-argoproj-argo-2.x
master
5f5150730c644865a5867bf017100732f55811dd
chore(deps): update module cenkalti/backoff to v4
renovate/github.com-cenkalti-backoff-4.x
master
v4.1.0
chore(deps): update module grpc-ecosystem/grpc-gateway to v2
renovate/github.com-grpc-ecosystem-grpc-gateway-2.x
master
v2.1.0
chore(deps): update module k8s.io/client-go to v12
renovate/k8s.io-client-go-12.x
master
v12.0.0
chore(deps): update module masterminds/squirrel to v1
renovate/github.com-masterminds-squirrel-1.x
master
d1a9a0e53225d7810c4f5e1136db32f4e360c5bb
chore(deps): update module mattn/go-sqlite3 to v2
renovate/github.com-mattn-go-sqlite3-2.x
master
v2.0.6
chore(deps): update module minio/minio-go to v7
renovate/github.com-minio-minio-go-7.x
master
v7.0.7
chore(deps): update module robfig/cron to v3
renovate/github.com-robfig-cron-3.x
master
v3.0.1
fix(deps): update dependency @google-cloud/storage to v5
renovate/major-googleapis-packages
master
^5.0.0
5.7.4
fix(deps): update dependency crypto-js to v4
renovate/crypto-js-4.x
master
^4.0.0
4.0.1
fix(deps): update dependency d3 to v6
renovate/d3-6.x
master
6.5.0
6.3.0
fix(deps): update dependency d3-dsv to v2
renovate/d3-dsv-2.x
master
2.0.0
2.0.1
fix(deps): update dependency http-proxy-middleware to v1
renovate/http-proxy-middleware-1.x
master
^1.0.0
1.0.6
fix(deps): update dependency js-yaml to v4
renovate/js-yaml-4.x
master
4.0.0
4.0.0
fix(deps): update dependency markdown-to-jsx to v7
renovate/markdown-to-jsx-7.x
master
7.1.1
fix(deps): update dependency mocha to v8
renovate/mocha-8.x
master
8.2.1
fix(deps): update dependency re-resizable to v6
renovate/re-resizable-6.x
master
6.9.0
fix(deps): update dependency react-ace to v9
renovate/react-ace-9.x
master
9.3.0
fix(deps): update dependency react-dropzone to v11
renovate/react-dropzone-11.x
master
11.2.4
fix(deps): update dependency react-router-dom to v5
renovate/major-reactrouter-monorepo
master
5.2.0
fix(deps): update dependency webdriverio to v6
renovate/major-webdriverio-monorepo
master
6.12.1
fix(deps): update mui monorepo (major)
renovate/major-mui-monorepo
master
4.11.3
4.11.2
fix(deps): update react monorepo to v17 (major)
renovate/major-react-monorepo
master
17.0.1
17.0.1
17.0.1
🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or spam the project. See docs for
prhourlylimit
for details.❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.
This PR has been generated by WhiteSource Renovate. View repository job log here.