Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a test. #51

Merged
merged 1 commit into from
Nov 5, 2018
Merged

This is a test. #51

merged 1 commit into from
Nov 5, 2018

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Nov 5, 2018

This change is Reviewable

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e8acb9 into master Nov 5, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Model default/canary with two configurations and one route

* Refactor updateStatus and add propagate functions for sub components

* Fix if error patterns

* Merge change for v1beta1 type
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
Fix: Fixing applying patch / CI failure
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Jun 20, 2024
UPSTREAM: <carry>: Fix for default Pipelineroot failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants