Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): enforce lower and upper bounds on all dependencies. #5258

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Mar 8, 2021

Description of your changes:

  • Fill in missing lower bounds using versions from SDK - Added pinned dependency snapshot #3303
  • Fill in missing upper bounds using the next major versions (assuming they all use semantic versioning, no the next major version could have incompatible changes).

Checklist:

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

/LGTM
/Hold
In case you need more feedback, feel free to unhold by yourself.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2021

/lgtm
Can you please update requirements.in as well?

@chensun
Copy link
Member Author

chensun commented Mar 15, 2021

/lgtm
Can you please update requirements.in as well?

Done.

/unhold

@Bobgy
Copy link
Contributor

Bobgy commented Mar 15, 2021

/LGTM
Thank you!

@google-oss-robot google-oss-robot merged commit 6502a8a into master Mar 15, 2021
@google-oss-robot google-oss-robot deleted the chensun-patch-1 branch March 15, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants