Fix gpu sample bug and add same notebook sample #605
Conversation
|
/assign @Ark-kun |
|
/test kubeflow-pipeline-build-image |
|
/lgtm |
|
/test kubeflow-pipeline-sample-test |
| @@ -102,7 +102,7 @@ def kubeflow_training(output, project, | |||
| # TODO: use the argo job name as the workflow | |||
| workflow = '{{workflow.name}}' | |||
| # set the flag to use GPU trainer | |||
| use_gpu = True | |||
| use_gpu = False | |||
There was a problem hiding this comment.
Why change the use_gpu to false?
There was a problem hiding this comment.
By default, the gpu is not enabled in kubeflow's deployment. I am going to add a doc about how to enable gpu in new/existing cluster and will put the doc link in comment here.
|
/test kubeflow-pipeline-sample-test |
|
New changes are detected. LGTM label has been removed. |
|
Discussed offline that we need to add sample tests to cover this GPU testing. |
|
/test kubeflow-pipeline-build-image |
|
The ml-pipeline-test doesn't have gpu quota. Requesting quota will take several days. I will revert my testing changes and continue without gpu disabled in sample in this PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hongye-sun: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This change is