Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added @gaoning777 and @Ark-kun to OWNERS #74

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Added @gaoning777 and @Ark-kun to OWNERS #74

merged 1 commit into from
Nov 6, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 6, 2018 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun Ark-kun requested a review from qimingj November 6, 2018 01:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: qimingj

If they are not already assigned, you can assign the PR to them by writing /assign @qimingj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qimingj
Copy link
Contributor

qimingj commented Nov 6, 2018

/lgtm /approve

@qimingj qimingj merged commit 8dbc308 into master Nov 6, 2018
@qimingj qimingj deleted the Ark-kun-patch-1 branch November 6, 2018 01:54
@google-prow-robot
Copy link
Collaborator

@Ark-kun: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
mlpipeline-presubmit-sample-test 7094623 link /test mlpipeline-presubmit-sample-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi @k8s-ci-robot
Add information about debugging failed tests. (kubeflow#74)
d1b994c 
* Add information about debugging failed tests.

* Add information about debugging failed deployments by getting K8s events.
* Add information about using Stackdriver logging to get pod logs for prow
  job.
* Fix kubeflow#45

* Add compute instance admin role because its needed for minikube.

* Address reviewer comments.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@hougangliu @k8s-ci-robot
Setup prow for kfserving (kubeflow#74)
64613ed 
* Fix test error of reconciler for configuration and route

* Setup prow for kfserving test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qimingj qimingj qimingj approved these changes

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @k8s-ci-robot @qimingj @google-prow-robot