Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

pytorch-operator: Consolidate manifests #322

Closed
yanniszark opened this issue Mar 17, 2021 · 1 comment
Closed

pytorch-operator: Consolidate manifests #322

yanniszark opened this issue Mar 17, 2021 · 1 comment

Comments

@yanniszark
Copy link
Contributor

Umbrella-Issue: kubeflow/manifests#1769

PyTorch Operator

Current manifests structure

.
├── crd.yaml
├── deployment.yaml
├── kustomization.yaml
├── namespace.yaml
├── podgroup.yaml
├── pytorch-job-crds
│   ├── base
│   └── overlays
│       └── application
├── pytorch-operator
│   ├── base
│   └── overlays
│       └── application

Explanation

Recommended end state

The main diff is that the upstream manifests also install a namespace resource, which we don't want when installing with kubeflow. Following the standard base and overlays structure, I propose the following structure:

├── base
├── overlays
│   ├── kubeflow
│   └── standalone
  • overlays/standalone is used to install the operator in its own namespace, for testing or other purposes.
  • overlays/kubeflow is used to install the operator as part of kubeflow.
@yanniszark
Copy link
Contributor Author

mistakenly opened

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant