Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 4: Consolidate manifests with multiple versions into 1 #1769

Closed
yanniszark opened this issue Mar 17, 2021 · 2 comments
Closed

Step 4: Consolidate manifests with multiple versions into 1 #1769

yanniszark opened this issue Mar 17, 2021 · 2 comments
Assignees

Comments

@yanniszark
Copy link
Contributor

Umbrella Issue: #1735

Some manifests (e.g., notebooks controller, katib) have multiple versions. Take
the example of notebook-controller:

diagram_3

There are the following versions of manifests:

  • The ones living in the upstream repo, used in development and testing.
  • The base and overlays folders, in kubeflow/manifests. These were
    optimized to work with kfctl's kustomization combination magic.
  • The base_v3 folder, designed to eschew vars and be buildable with
    kustomize. It imports files from base.

Consolidate multiple manifests versions into one.

@yanniszark
Copy link
Contributor Author

yanniszark commented Mar 19, 2021

Here is a matrix with the remaining work:

App PR Merged
PodDefaults kubeflow/kubeflow#5719 ✔️
Jupyter Web App kubeflow/kubeflow#5721 ✔️
CentralDashboard kubeflow/kubeflow#5720 ✔️
Profiles + KFAM kubeflow/kubeflow#5718 ✔️
Notebook Controller kubeflow/kubeflow#5723 ✔️
TF-Operator kubeflow/training-operator#1255 kubeflow/training-operator#1259 ✔️
PyTorch-Operator kubeflow/pytorch-operator#323 ✔️
MXNet Operator kubeflow/mxnet-operator#91 ✔️
MPI Operator kubeflow/mpi-operator#340 ✔️
XGBoost Operator kubeflow/xgboost-operator#114 ✔️

@yanniszark
Copy link
Contributor Author

Closing as all manifests were consolidated.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant