Issues deploying the helm chart for spark-on-k8s-operator using argocd #1143
Comments
liyinan926
pushed a commit
that referenced
this issue
Jan 28, 2021
…and CRD validation fixes (#1145) A new version of the helm chart should be released which contains configurable webhook-cleanup-job annotations, as the helm-hook pre-update doesn't work with argocd, and the CRD fixes which are failing validation. Signed-off-by: Tom Hellier <[email protected]>
|
My PR was merged, so can close this |
tandrup
added a commit
to tandrup/spark-on-k8s-operator
that referenced
this issue
Feb 5, 2021
This enables users to install the chart using ArgoCD without setting special values. This solves kubeflow#1143 without requiring setting special values in values.yaml like the PR kubeflow#1145 requires.
liyinan926
pushed a commit
that referenced
this issue
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm attempting to deploy the latest version of the spark-on-k8s-operator using argocd 1.7.6, and I've encountered a few problems.
Helm lifecycle hooks
The webhook-cleanup-job annotations specify they should run on pre-delete and pre-upgrade, this is interfering with the way argocd deploys helm charts and causing the spark-on-k8s-operator to never deploy, as the cleanup job first attempts to mount the service account before it has been created. I've found if I configure the values files locally to remove the pre-upgrade, the helm chart deploys and is useable, but whether this is a suitable long term solution I'm not sure. The change to this section of the helm chart just opens that section up to be configured without changing the default helm hooks that was there originally.
It looks like several people have had this issue before judging by the end comments in this issue, and this is the only helm chart with that issue exposed: argoproj/argo-cd#355
Spark CRDs malformed
The creation timestamp would be better left out, as it that line is created automatically when the CRD is deployed, and the
conditionsandstoredVersionsare better set to the empty list instead of null, as they currently fail validation.I've managed to get the helm chart deployed using some local changes, and am happy to provide them if you wanted to merge the changes in.
The text was updated successfully, but these errors were encountered: