Remove applications.py; commonLabels should be immutable. #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See kubeflow/manifests#1131 we want commonLabels to be immutable otherwise upgrades won't work because we end up trying to change selectors which are immutable. * The applications.py script inherently violates that because it was mutating commonLabels on every release. We don't want to do that anymore so we delete the script.
|
This change is |
|
/assign @yanniszark |
|
@jlewi thanks for the PR! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commonLabels need to be immutable for upgrades - remove version from commonLabels manifests#1131 we want commonLabels to be immutable
otherwise upgrades won't work because we end up trying to change
selectors which are immutable.
The applications.py script inherently violates that because it was
mutating commonLabels on every release. We don't want to do that
anymore so we delete the script.