Add tekton tasks for eks-cluster-create/teardown and kaniko #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickXYS
reviewed
Jan 25, 2021
...s/clusters/optional-test-infra-tekton/namespaces/kubeflow-test-infra/eks-cluster-create.yaml
Outdated
Show resolved
Hide resolved
| default: "4" | ||
| description: The maximum number of nodes in the cluster. | ||
| workspaces: | ||
| - name: secrets |
There was a problem hiding this comment.
added a sample secrets file
* add sample file for aws-credentials secret
|
/lgtm @theofpa Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PatrickXYS, theofpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Add three reusable tasks from tekton hub:
The kaniko image is modified to fetch a custom built image until the pending PRs awslabs/amazon-ecr-credential-helper#253, GoogleContainerTools/kaniko#1515 and GoogleContainerTools/kaniko#1543 will be merged and released to have ECR-public support in kaniko. More information here.
Checklist:
If PR related to Optional-Test-Infra,
aws/GitOpsfolder:cd awsmake optional-generatemake optional-test