add pytorch API and controller #1294
Conversation
|
@zw0610 Are there any changes from the source? |
| Scheme: mgr.GetScheme(), | ||
| }).SetupWithManager(mgr); err != nil { | ||
| setupLog.Error(err, "unable to create controller", "controller", "XGBoostJob") | ||
| if err = pytorchcontroller.NewReconciler(mgr).SetupWithManager(mgr); err != nil { |
There was a problem hiding this comment.
it might have some conflicts with #1293 after the merge. I can handle the conflicts.
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package v1 |
There was a problem hiding this comment.
This file is not from Kubebuilder. right?
There was a problem hiding this comment.
right, this is copied from pytorch-operator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
... Seems bot now detects the |
For the API part, little. For the controller part, a lot. As we are adopting the reconciler mode, the pytorch-operator controller changes the code from setting up the controller to reconciling a pytorch job. Although we are using the reconcile method from |
|
part of kubeflow/common#138 #1298 |
Add PyTorch API and controller into all-in-one branch.
Tested with create and delete pytorch job.
/cc @Jeffwan