Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MXJob v1 api and controller #1296

Merged
merged 1 commit into from
Jul 11, 2021
Merged

Add MXJob v1 api and controller #1296

merged 1 commit into from
Jul 11, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Jul 10, 2021

  • Generate MXJob api and manifests
  • Rewrite MXNet controller logic in reconciler pattern

Signed-off-by: Jiaxin Shan [email protected]

@Jeffwan Jeffwan requested review from zw0610 and terrytangyuan and removed request for terrytangyuan and jinchihe July 10, 2021 23:44
@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 10, 2021

/cc @kubeflow/wg-training-leads

@google-oss-robot google-oss-robot requested a review from a team July 10, 2021 23:46
@Jeffwan Jeffwan mentioned this pull request Jul 10, 2021
Open
@Jeffwan
Add MXJob v1 api and controller
e7a4486 
- Generate MXJob api and manifests
- Rewrite MXNet controller logic in reconciler pattern

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 11, 2021

I just rebase the upstream and resolve the merge conflicts

terrytangyuan
terrytangyuan reviewed Jul 11, 2021
View reviewed changes
.gitignore
@@ -3,6 +3,9 @@
bin/
/tf-operator
vendor/
testbin/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this being generated from?

Copy link
Member Author

@Jeffwan Jeffwan Jul 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrytangyuan

It's from make test command. https://github.com/kubeflow/tf-operator/blob/91ae0a8219085230d571f1c1df0808ca9b20d09e/Makefile#L52-L56

command automatically creates ./testbin

zw0610
zw0610 approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@zw0610 zw0610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

terrytangyuan
terrytangyuan approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 11, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 9e7e09f into kubeflow:all-in-one-operator Jul 11, 2021
@Jeffwan Jeffwan deleted the mxnet branch July 11, 2021 16:49
@Jeffwan Jeffwan mentioned this pull request Jul 11, 2021
Closed
@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 11, 2021 •
edited
Loading

part of kubeflow/common#138 #1298

Jeffwan added a commit that referenced this pull request Aug 5, 2021
@Jeffwan
Add MXJob v1 api and controller (#1296)
10b6c48 
- Generate MXJob api and manifests
- Rewrite MXNet controller logic in reconciler pattern

Signed-off-by: Jiaxin Shan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@zw0610 zw0610 zw0610 approved these changes

Assignees

@terrytangyuan terrytangyuan

@zw0610 zw0610

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeffwan @google-oss-robot @terrytangyuan @zw0610