Clean up manifests and remove unused files

[Jeffwan]

A follow up PR of #1346. part of #1322

/cc @deepak-muley

1. Merge viewer/editor role into one
2. Remove unused roles (we created two roles in the manifest. manifests/config is not being used as well)
3. Update images

[google-oss-robot]

@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: deepak-muley.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

A follow up PR of #1346. part of #1322

/cc @deepak-muley

1. Merge viewer/editor role into one
2. Remove unused roles (we created two roles in the manifest)
3. Update images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Jeffwan]

/cc @deepak-muley @johnugeorge

[google-oss-robot]

@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: deepak-muley.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @deepak-muley @johnugeorge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[terrytangyuan]

/lgtm
/hold

[andreyvelich]

Currently, we don't use Prometheus manifests.
Would it better to add this manifest when we create separate overlay with Prometheus support ?

[deepak-muley]

Currently, we don't use Prometheus manifests.
Would it better to add this manifest when we create separate overlay with Prometheus support ?

I agree. we should add an overlay with kubeflow and standalone with servicemonitor resource in kustomize. Do we expect prometheus CRDs to be present?

[Jeffwan]

@andreyvelich @terrytangyuan @deepak-muley Please have another check

1. Remove manifests/manager folder
2. Remove manifests/prometheus folder
3. Remove duplicate viewer/editor roles. Update the original ones to support more crds

[andreyvelich]

@Jeffwan Do we need Leader Election Role and Leader Election Role Binding.

We can track these roles within Controller Manager config issue.

[Jeffwan]

@Jeffwan Do we need Leader Election Role and Leader Election Role Binding.

We can track these roles within Controller Manager config issue.

yeah, @deepak-muley will file a separate issue to enable leader election in #1350

[andreyvelich]

yeah, @deepak-muley will file a separate issue to enable leader election in #1350

I was thinking that maybe we can remove this role for now ?
We can decide the location for these files once we resolve this issue: #1350

[Jeffwan]

@andreyvelich Sounds good. I deleted them.

[andreyvelich]

Thank you @Jeffwan!
/lgtm
/hold for other reviews.

cc @terrytangyuan

[deepak-muley]

/lgtm

[google-oss-robot]

@deepak-muley: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Jeffwan]

/approve
/unhold

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepak-muley, Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Jeffwan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment