Skip to content

Commit

Permalink
Trim down CRD descriptions (#1735)
Browse files Browse the repository at this point in the history
* Trim down CRD descriptions

Trim down CRD descriptions to avoid the following apply errors:

```
The CustomResourceDefinition "pytorchjobs.kubeflow.org" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
```

* 400 characters

Signed-off-by: Yuki Iwai <[email protected]>

Signed-off-by: Yuki Iwai <[email protected]>
  • Loading branch information
tenzen-y authored Jan 21, 2023
1 parent 6383a91 commit ed33bd9
Show file tree
Hide file tree
Showing 7 changed files with 629 additions and 3,473 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Image URL to use all building/pushing image targets
IMG ?= kubeflow/training-operator:latest
# CRD generation options
CRD_OPTIONS ?= "crd:generateEmbeddedObjectMeta=true"
CRD_OPTIONS ?= "crd:generateEmbeddedObjectMeta=true,maxDescLen=400"

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
Expand Down
681 changes: 104 additions & 577 deletions manifests/base/crds/kubeflow.org_mpijobs.yaml

Large diffs are not rendered by default.

681 changes: 104 additions & 577 deletions manifests/base/crds/kubeflow.org_mxjobs.yaml

Large diffs are not rendered by default.

688 changes: 106 additions & 582 deletions manifests/base/crds/kubeflow.org_paddlejobs.yaml

Large diffs are not rendered by default.

688 changes: 106 additions & 582 deletions manifests/base/crds/kubeflow.org_pytorchjobs.yaml

Large diffs are not rendered by default.

681 changes: 104 additions & 577 deletions manifests/base/crds/kubeflow.org_tfjobs.yaml

Large diffs are not rendered by default.

681 changes: 104 additions & 577 deletions manifests/base/crds/kubeflow.org_xgboostjobs.yaml

Large diffs are not rendered by default.

0 comments on commit ed33bd9

Please sign in to comment.