Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): Update k8s related package to 0.19.9, kubeflow/common to 0.3.6 WIP #1308

Closed
wants to merge 0 commits into from

Conversation

gaocegege
Copy link
Member

Fixes #1306

  • Test it locally

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we are freezing master branch until the unified operator is merged?

@gaocegege
Copy link
Member Author

@Jeffwan @zw0610 WDYT

There are some bugs reported by our internal customers. If we decide to freeze it, we can hold it and I will fix it internally.

@johnugeorge
Copy link
Member

How long should we hold? what are the blocking issues? @Jeffwan

@gaocegege
Copy link
Member Author

/retest

@Jeffwan
Copy link
Member

Jeffwan commented Jul 28, 2021

@gaocegege @johnugeorge @terrytangyuan

There're similar changes in all-in-one-operator branch #1290 #1292

I plan to polish codes in dev branch and make it work this week. Then we can merge back to master and evolving changes in master instead.

@gaocegege If you have internal branch, please help fix it internally first? Since we plan to rebase changes to master pretty soon. We can save some efforts on merging later.

@gaocegege
Copy link
Member Author

OK SGTM

@Jeffwan
Copy link
Member

Jeffwan commented Aug 6, 2021

@gaocegege When you get a chance, let's just bump the version and send a separate PR? please help cherry-pick the changes to v1.2-branch

@gaocegege
Copy link
Member Author

SGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] The pod wil be recreated until the expectation expires
5 participants