Remove uncalled mpi-controller DeletePodsAndServices()

[cheimu]

What this PR does / why we need it:
mpi-controller's DeletePodsAndServices() is a dead code which is never called, very confusing and very misleading. All of controllers use the base job-controller to reconcile and the base will call jc.DeletePodsAndServices() without using subclass's(such as mpijob, pytorchjob, .etc). It is better to remove it.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

• Docs included if any changes are user facing

[aws-kf-ci-bot]

Hi @cheimu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 2020035866

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 37.234%

---

Totals
Change from base Build 2014597889:	0.3%
Covered Lines:	2291
Relevant Lines:	6153

---

💛 - Coveralls

[zw0610]

/ok-to-test

[gaocegege]

LGTM 👍
/lgtm

[zw0610]

@hackerboy01 Please take a look at this pull request and make sure this change should not affect our internal clusters.

[zw0610]

/hold for today as more test may be necessary.

[hackerboy01]

What this PR does / why we need it: mpi-controller's DeletePodsAndServices() is a dead code which is never called, very confusing and very misleading. All of controllers use the base job-controller to reconcile and the base will call jc.DeletePodsAndServices() without using subclass's(such as mpijob, pytorchjob, .etc). It is better to remove it.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Fixes #

Checklist:

• Docs included if any changes are user facing

What this PR does / why we need it: mpi-controller's DeletePodsAndServices() is a dead code which is never called, very confusing and very misleading. All of controllers use the base job-controller to reconcile and the base will call jc.DeletePodsAndServices() without using subclass's(such as mpijob, pytorchjob, .etc). It is better to remove it.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Fixes #

Checklist:

• Docs included if any changes are user facing
  As describe in issues linked below, if the second has been fixed, mpi-controller's DeletePodsAndServices() will be called.
  fix label and CleanPodPolicy for mpi-controller #1550 (comment)

[zw0610]

/unhold

[zw0610]

/lgtm

[zw0610]

/approve

[zw0610]

thank you for this pull request. I've discussed with @hackerboy01 and made sure this function can be removed.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheimu, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zw0610]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment