Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MPI python sdk #1608

Merged
merged 28 commits into from
Jun 10, 2022
Merged

Adding MPI python sdk #1608

merged 28 commits into from
Jun 10, 2022

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Jun 10, 2022

MPI python sdk is added with e2e test.

This PR has extra changes

  1. job-role for MPIReplicaTypeLauncher pod is set to master in MPI controller so that logs are fetched from launcher pod by default. This is consistent with other frameworks.
  2. In sdk, training.kubeflow.org prefix is added to job-role, job-name and replica-index labels which are used for getting pod names.

@coveralls
Copy link

coveralls commented Jun 10, 2022

Pull Request Test Coverage Report for Build 2472869982

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 37.034%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/tensorflow/tfjob_controller.go 3 70.62%
pkg/controller.v1/mpi/mpijob_controller.go 5 78.37%
Totals Coverage Status
Change from base Build 2471254094: 0.1%
Covered Lines: 2315
Relevant Lines: 6251

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants