-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MPI python sdk #1608
Adding MPI python sdk #1608
Conversation
Pull Request Test Coverage Report for Build 2472869982
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MPI python sdk is added with e2e test.
This PR has extra changes
job-role
forMPIReplicaTypeLauncher
pod is set tomaster
in MPI controller so that logs are fetched from launcher pod by default. This is consistent with other frameworks.training.kubeflow.org
prefix is added tojob-role
,job-name
andreplica-index
labels which are used for getting pod names.