Fix the default LeaderElectionID and make it an argument #1639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the default leader election ID which has an invalid format. If one enables leader election through
leader-elect=true
, the operator fails to start with the following error:Before:
Fails to acquire lease:
E0727 20:44:04.107669 1889297 leaderelection.go:334] error initially creating leader election record: Lease.coordination.k8s.io "1ca428e5." is invalid: metadata.name: Invalid value: "1ca428e5.": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
After:
Successfully acquires lease:
I0727 20:44:40.727719 1890098 leaderelection.go:248] attempting to acquire leader lease kubeflow/1ca428e5.training-operator.kubeflow.org... I0727 20:44:57.469968 1890098 leaderelection.go:258] successfully acquired lease kubeflow/1ca428e5.training-operator.kubeflow.org
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1640
Checklist: