Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][SDK] pod has no metadata attr anymore in the get_job_logs() … #1760

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

yaobaiwei
Copy link
Contributor

@yaobaiwei yaobaiwei commented Feb 16, 2023

What this PR does / why we need it:

In the get_job_logs() func of the newly unified Training Client of python sdk, as the return type of get_job_pod_names() is [str] now, no metadata attr for log anymore.

A careless bug I believe, just found it when I was testing my own proj.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@google-cla
Copy link

google-cla bot commented Feb 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and fixing this @yaobaiwei!
Please sign the CLA
/lgtm

@coveralls
Copy link

coveralls commented Feb 16, 2023

Pull Request Test Coverage Report for Build 4196610894

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 39.356%

Totals Coverage Status
Change from base Build 4193123906: 0.03%
Covered Lines: 2725
Relevant Lines: 6924

💛 - Coveralls

@johnugeorge
Copy link
Member

Thanks @yaobaiwei

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, johnugeorge, yaobaiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ea97855 into kubeflow:master Feb 16, 2023
google-oss-prow bot pushed a commit that referenced this pull request Feb 16, 2023
* Update sdk to v1.6.0rc0

* Update sdk to v1.6.0rc0

* Update sdk to v1.6.0rc0

* Update to latest Image

* [Bugfix][SDK] pod has no metadata attr anymore in the get_job_logs() … (#1760)

---------

Co-authored-by: Hongzhi Chen <[email protected]>
google-oss-prow bot pushed a commit that referenced this pull request Mar 21, 2023
* Update sdk to v1.6.0rc0

* Update sdk to v1.6.0rc0

* Update sdk to v1.6.0rc0

* Update to latest Image

* [Bugfix][SDK] pod has no metadata attr anymore in the get_job_logs() … (#1760)

* Update sdk version in files to 1.6.0

---------

Co-authored-by: Hongzhi Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants