-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade controller-gen to v0.14.0 #2026
fix: Upgrade controller-gen to v0.14.0 #2026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Thanks!
@kubeflow/wg-training-leads Could you approve CI?
Pull Request Test Coverage Report for Build 8319762885Details
💛 - Coveralls |
@champon1020 Could you re-generate CRD? |
7ca7b2c
to
cf040ef
Compare
@tenzen-y Now I re-generated CRD by |
The building failed due to unintended errors:
@deepanker13 Could you investigate this? |
Sure, looking into it |
Sorry, I put an irrelevant link above. The correctly link is https://github.com/kubeflow/training-operator/actions/runs/8282278962/job/22664907995?pr=2026#step:5:1615 |
@deepanker13 @champon1020 We will fix the dependencies issue in #2031. |
@champon1020 Could you rebase this PR since we fixed CI issues? |
Signed-off-by: champon1020 <[email protected]>
Signed-off-by: champon1020 <[email protected]>
cf040ef
to
a05d8e4
Compare
@kubeflow/wg-training-leads Could you approve CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for great contribution!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: champon1020, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
* fix: upgrade controller-gen to v0.14.0 Signed-off-by: champon1020 <[email protected]> * gen: make manifests to re-generate crd Signed-off-by: champon1020 <[email protected]> --------- Signed-off-by: champon1020 <[email protected]>
* fix: upgrade controller-gen to v0.14.0 Signed-off-by: champon1020 <[email protected]> * gen: make manifests to re-generate crd Signed-off-by: champon1020 <[email protected]> --------- Signed-off-by: champon1020 <[email protected]> Signed-off-by: deepanker13 <[email protected]>
* fix: upgrade controller-gen to v0.14.0 Signed-off-by: champon1020 <[email protected]> * gen: make manifests to re-generate crd Signed-off-by: champon1020 <[email protected]> --------- Signed-off-by: champon1020 <[email protected]>
* fix: upgrade controller-gen to v0.14.0 Signed-off-by: champon1020 <[email protected]> * gen: make manifests to re-generate crd Signed-off-by: champon1020 <[email protected]> --------- Signed-off-by: champon1020 <[email protected]>
What this PR does / why we need it:
Upgrade controller-gen to v0.14.0, in order to avoid runtime panic when conducting
make install
with Go 1.22.(About this problem and solution is mentioned in controller-gen: #888)
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #2025
Checklist: