-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong filepath in the simple example command #2062
Conversation
Signed-off-by: dingbj91 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this change and it works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! But, based on my comment, I'm closing this PR.
/close
@@ -16,7 +16,7 @@ spec: | |||
imagePullPolicy: Always | |||
command: | |||
- "python3" | |||
- "/opt/mnist/src/mnist.py" | |||
- "/opt/pytorch-mnist/mnist.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct in the master branch.
Please see
ENTRYPOINT ["python", "/opt/mnist/src/mnist.py"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my understanding is not correct since we are using the katib image here: https://github.com/kubeflow/katib/blob/21320b6d5774e4a7828a2c49e4bff75cd55e6b35/examples/v1beta1/trial-images/pytorch-mnist/Dockerfile.cpu#L17
/reopen
@tenzen-y: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tenzen-y: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 8717139989Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qzoscar, seetharamiseelam, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: dingbj91 <[email protected]> Signed-off-by: Weiyu Yen <[email protected]>
Signed-off-by: dingbj91 <[email protected]>
Signed-off-by: dingbj91 <[email protected]>
What this PR does / why we need it:
some filepath is wrong in the simple example
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: