Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong filepath in the simple example command #2062

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

qzoscar
Copy link
Contributor

@qzoscar qzoscar commented Apr 13, 2024

What this PR does / why we need it:
some filepath is wrong in the simple example
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Copy link

@seetharamiseelam seetharamiseelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this change and it works...

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! But, based on my comment, I'm closing this PR.
/close

@@ -16,7 +16,7 @@ spec:
imagePullPolicy: Always
command:
- "python3"
- "/opt/mnist/src/mnist.py"
- "/opt/pytorch-mnist/mnist.py"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct in the master branch.
Please see

ENTRYPOINT ["python", "/opt/mnist/src/mnist.py"]
for more details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@google-oss-prow google-oss-prow bot closed this Apr 15, 2024
Copy link

@tenzen-y: Closed this PR.

In response to this:

Thank you for this contribution! But, based on my comment, I'm closing this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot reopened this Apr 17, 2024
Copy link

@tenzen-y: Reopened this PR.

In response to this:

Sorry, my understanding is not correct since we are using the katib image here: https://github.com/kubeflow/katib/blob/21320b6d5774e4a7828a2c49e4bff75cd55e6b35/examples/v1beta1/trial-images/pytorch-mnist/Dockerfile.cpu#L17

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8717139989

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 35.269%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 80.67%
Totals Coverage Status
Change from base Build 8710103622: -0.05%
Covered Lines: 4373
Relevant Lines: 12399

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qzoscar, seetharamiseelam, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d1388e9 into kubeflow:master Apr 17, 2024
37 of 38 checks passed
ckyuto pushed a commit to ckyuto/training-operator that referenced this pull request Apr 26, 2024
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants