Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tf job examples to tf v2 #2270

Merged

Conversation

YosiElias
Copy link
Contributor

@YosiElias YosiElias commented Sep 25, 2024

What this PR does / why we need it:
Update TFjob examples to TF v2

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2015

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11662420881

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11645970070: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

@YosiElias
Copy link
Contributor Author

Hi @alongzhi, I saw you added ppc64le images before.
In order to support ppc64le I need base image of TF-v2 to replace this image - ibmcom/tensorflow-ppc64le:1.13.1 that used in: examples/tensorflow/dist-mnist/Dockerfile.ppc64le and examples/tensorflow/mnist_with_summaries/Dockerfile.ppc64le.

Can you pls support this image? otherwise just let me know and I'll remove this Dockerfile.ppc64le since the source code support only TF-v2 now..

@JosepSampe @ckadner Do you know who can support this image from IBM?

@andreyvelich - FYI

@andreyvelich
Copy link
Member

@alongzhi Are you planning to continue support powerPC images in Training Operator ?
Otherwise, we will remove them.
cc @kubeflow/wg-training-leads

@YosiElias
Copy link
Contributor Author

/assign @kuizhiqing

@andreyvelich
Copy link
Member

@YosiElias Please can you rebase your PR to fix unit tests ?

@YosiElias YosiElias force-pushed the update_TFJob_examples_to_TF_v2 branch from 45c8e8c to 28d48b4 Compare October 29, 2024 15:40
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @YosiElias!
/lgtm
/assign @kubeflow/wg-training-leads

@andreyvelich
Copy link
Member

/rerun-all

Signed-off-by: yelias <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 4, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 4, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 95be3c0 into kubeflow:master Nov 4, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt TFJob examples to TensorFlow v2
5 participants