-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tf job examples to tf v2 #2270
Update tf job examples to tf v2 #2270
Conversation
Pull Request Test Coverage Report for Build 11662420881Details
💛 - Coveralls |
Hi @alongzhi, I saw you added ppc64le images before. Can you pls support this image? otherwise just let me know and I'll remove this Dockerfile.ppc64le since the source code support only TF-v2 now.. @JosepSampe @ckadner Do you know who can support this image from IBM? @andreyvelich - FYI |
@alongzhi Are you planning to continue support powerPC images in Training Operator ? |
/assign @kuizhiqing |
@YosiElias Please can you rebase your PR to fix unit tests ? |
Signed-off-by: yelias <[email protected]>
Signed-off-by: yelias <[email protected]>
Signed-off-by: yelias <[email protected]>
Signed-off-by: yelias <[email protected]>
… distribution_strategy Signed-off-by: yelias <[email protected]>
Signed-off-by: yelias <[email protected]>
Signed-off-by: yelias <[email protected]>
45c8e8c
to
28d48b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this @YosiElias!
/lgtm
/assign @kubeflow/wg-training-leads
/rerun-all |
Signed-off-by: yelias <[email protected]>
… into update_TFJob_examples_to_TF_v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Update TFjob examples to TF v2
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #2015
Checklist: