Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for Katib Trials count #2321

Merged

Conversation

andreyvelich
Copy link
Member

Fixes: kubeflow/katib#1286.
Blocked by: #2312.

I added information about default values for parallelTrialCount and maxTrialCount. Other default values we will explain in a appropriate PRs.

/assign @gaocegege @johnugeorge
/cc @8bitmp3 @RFMVasconcelos

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@andreyvelich andreyvelich force-pushed the issue-1286-default-katib-api-values branch from 4450c7a to a04de33 Compare November 11, 2020 13:55
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich andreyvelich changed the title [WIP] Default values for Katib Trials count Default values for Katib Trials count Nov 11, 2020
@andreyvelich
Copy link
Member Author

This PR is ready.
/cc @8bitmp3 @gaocegege @johnugeorge

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 7aa7071 into kubeflow:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Controller logic for defaults Experiment API parameters
6 participants