Add doc for rollout model #280
Conversation
| `"10.32.0.0/14\,10.35.240.0/20"`. | ||
|
|
||
| 6. Install istio (without mTLS) | ||
| ### 4. Configure istio-ingressgateway | ||
| We are using a regular ingress instead of Istio's ingressgateway as the entry to cluster, so this service should not |
There was a problem hiding this comment.
typo "ingressgateway" -> "ingress gateway"
Should we clarify that on GCP we recommend using NodePort and GCLB but on other platforms you might want to use ISTIO ingress?
| @@ -85,6 +99,9 @@ like | |||
| See istio [doc](https://istio.io/docs/tasks/telemetry/metrics-logs.html). | |||
|
|
|||
| #### Expose Grafana dashboard behind ingress/IAP | |||
|
|
|||
| TODO(lunkai): update this section | |||
There was a problem hiding this comment.
Can we put TODOs in comments so that won't be rendered? Can we also link TODOs to issues instead of people?
There was a problem hiding this comment.
link to issue instead of person now.
I think render the TODO is better so that people know this part is not up-to-date.
|
cc @ellis-bigelow |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeflow/kubeflow#1309
kubeflow/kubeflow#1844
/cc @jlewi
This change is