Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in the MXNET training operator page #2966

Merged
merged 1 commit into from
Sep 22, 2021
Merged

fix typo in the MXNET training operator page #2966

merged 1 commit into from
Sep 22, 2021

Conversation

pramodrj07
Copy link
Contributor

@google-cla google-cla bot added the cla: yes label Sep 21, 2021
@google-oss-robot
Copy link

Hi @pramodrj07. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pramodrj07
Copy link
Contributor Author

/assign @Jeffwan

Arhell
Arhell reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pramodrj07 added a commit to pramodrj07/internal-acls that referenced this pull request Sep 21, 2021
@pramodrj07
Add pramodrj07 to the member list
de166c3 
List of contributions
1. kubeflow/website#2965
2. kubeflow/website#2966
3. kubeflow/training-operator#1411
@pramodrj07 pramodrj07 mentioned this pull request Sep 21, 2021
Open
@Jeffwan
Copy link
Member

Jeffwan commented Sep 22, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, pramodrj07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 0cf15ca into kubeflow:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@Jeffwan Jeffwan Jeffwan approved these changes

@berndverst berndverst Awaiting requested review from berndverst

Assignees

@Jeffwan Jeffwan

@Arhell Arhell

Labels
approved cla: yes lgtm needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pramodrj07 @google-oss-robot @Jeffwan @Arhell