Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pipelines): Explain Metadata dependency and deprecation of kubeflow/metadata #3082

Merged
merged 4 commits into from
Nov 30, 2021
Merged

(pipelines): Explain Metadata dependency and deprecation of kubeflow/metadata #3082

merged 4 commits into from
Nov 30, 2021

Conversation

zijianjoy
Copy link
Contributor

@zijianjoy zijianjoy commented Nov 28, 2021 •
edited
Loading

As part of deprecation for inactive Kubeflow repos, putting on a page to explain metadata and how KFP depends on the OSS version of ml-metadata.

kubeflow/community#479

@google-cla google-cla bot added the cla: yes label Nov 28, 2021
Arhell
Arhell reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @Bobgy

@google-oss-prow google-oss-prow bot added size/L and removed size/S labels Nov 29, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shannonbradshaw
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 30, 2021
@google-oss-prow google-oss-prow bot merged commit 57053bf into kubeflow:master Nov 30, 2021
@thesuperzapper
Copy link
Member

@zijianjoy was the models.txt file accidentally included in this PR?

It seems a bit random.

@thesuperzapper thesuperzapper mentioned this pull request Dec 1, 2021
Closed
@thesuperzapper
Copy link
Member

I have raised #3085 which (among other things) removes the modules.txt file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonbradshaw shannonbradshaw shannonbradshaw requested changes

@Arhell Arhell Arhell left review comments

@theadactyl theadactyl Awaiting requested review from theadactyl

@alfsuse alfsuse Awaiting requested review from alfsuse

@joeliedtke joeliedtke Awaiting requested review from joeliedtke

Assignees

@shannonbradshaw shannonbradshaw

@Bobgy Bobgy

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zijianjoy @shannonbradshaw @thesuperzapper @Arhell @Bobgy