Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Kubeflow Notebooks container images docs #3609

Merged

Conversation

thesuperzapper
Copy link
Member

This PR updates the docs to align with the changes made for Kubeflow 1.8 in kubeflow/kubeflow#7357.

Note, to get mermaid graphs working, I had to update both hugo and docsy, which is why there is a large number of non-content diffs.

@thesuperzapper
Copy link
Member Author

@zijianjoy since I had to update hugo and docsy (which updates files at the root), I will need you to approve this.

/assign @zijianjoy
/cc @kimwnasptd

Copy link
Contributor

@zijianjoy zijianjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you for the upgrade!

@google-oss-prow google-oss-prow bot added the lgtm label Oct 25, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6ab922c into kubeflow:master Oct 25, 2023
6 checks passed
@thesuperzapper thesuperzapper deleted the update-notebook-images branch October 25, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants